-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: localize draw #2068
feature: localize draw #2068
Conversation
There is a little bit faulty on the translation. |
Thanks for the feedback. I did experience difficulties with the English terms for "kors" and "kryss"-symbols. (Obviously "Ask an LLM" wasn't immediately the right move. Humans are still better at some things :P ) So "pointTypeCross": "Kors",
"pointTypeCheckmark": "Kryss", can become "pointTypePlus": "Kors",
"pointTypeX": "Kryss", In English "pointTypePlus": "Plus",
"pointTypeX": "Cross",
(or) "pointTypeX": "X" What was that about a blank space separation? |
You had "Checkmark", but the correct would have been "Check mark". |
Should be ok now. |
Nah, seems to still be confusing between cross and plus. |
Please specify what you would like to see then, I did provide suggestions earlier : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is what I meant was wrong.
src/loc/en_US.json
Outdated
"pointTypePoint": "Point", | ||
"pointTypeCircle": "Circle", | ||
"pointTypeX": "X", | ||
"pointTypePlus": "Cross", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"pointTypePlus": "Cross" should be "pointTypePlus": "Plus"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got ya. Should the sv_SE translation be "pointTypePlus": "Plus"
or are we used to "Kors"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Kors" works in swedish and "Plus" would also be appropriate in swedish, so I don't know which is best.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Aims to fix #2065 (the long way around)
Some testing would be good, around measure and draw. I've done some testing and I have gotten most of the strings and numbers but do tell if there's something missing (or a crash, I've changed a number of function signatures but who likes
formatArea(undefined, 0, undefined, undefined, cat)
?)The editor appears to have parallel files and I haven't tested it.