Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: localize draw #2068

Merged
merged 4 commits into from
Nov 15, 2024
Merged

feature: localize draw #2068

merged 4 commits into from
Nov 15, 2024

Conversation

Grammostola
Copy link
Contributor

Aims to fix #2065 (the long way around)

Some testing would be good, around measure and draw. I've done some testing and I have gotten most of the strings and numbers but do tell if there's something missing (or a crash, I've changed a number of function signatures but who likes formatArea(undefined, 0, undefined, undefined, cat)?)

The editor appears to have parallel files and I haven't tested it.

@johnnyblasta
Copy link
Collaborator

There is a little bit faulty on the translation.
On the types of points.
Check mark refers to a example check icons
Cross mark (also known as 'X mark') refers to a example cross icons
Plus mark refers to a example plus icons
Also notice the blank space separation.

@Grammostola
Copy link
Contributor Author

Grammostola commented Nov 14, 2024

Thanks for the feedback. I did experience difficulties with the English terms for "kors" and "kryss"-symbols. (Obviously "Ask an LLM" wasn't immediately the right move. Humans are still better at some things :P )

So

           "pointTypeCross": "Kors",
            "pointTypeCheckmark": "Kryss",

can become

           "pointTypePlus": "Kors",
            "pointTypeX": "Kryss",

In English

           "pointTypePlus": "Plus",
            "pointTypeX": "Cross",

(or)

"pointTypeX": "X"

What was that about a blank space separation?

@johnnyblasta
Copy link
Collaborator

What was that about a blank space separation?

You had "Checkmark", but the correct would have been "Check mark".
If you don't use "mark" or "sign" as in your suggestion above there is no need for "särskrivning"

@Grammostola
Copy link
Contributor Author

Should be ok now.

@johnnyblasta
Copy link
Collaborator

Should be ok now.

Nah, seems to still be confusing between cross and plus.

@Grammostola
Copy link
Contributor Author

Please specify what you would like to see then, I did provide suggestions earlier : )

Copy link
Collaborator

@johnnyblasta johnnyblasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is what I meant was wrong.

"pointTypePoint": "Point",
"pointTypeCircle": "Circle",
"pointTypeX": "X",
"pointTypePlus": "Cross",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"pointTypePlus": "Cross" should be "pointTypePlus": "Plus"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got ya. Should the sv_SE translation be "pointTypePlus": "Plus" or are we used to "Kors"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Kors" works in swedish and "Plus" would also be appropriate in swedish, so I don't know which is best.

Copy link
Collaborator

@johnnyblasta johnnyblasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Grammostola Grammostola merged commit 260dae2 into master Nov 15, 2024
4 checks passed
@Grammostola Grammostola deleted the localize_draw branch November 15, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawing disappears when show length/area or sections
2 participants