Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: OL v10.2.0 and some other deps #2051

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

jokd
Copy link
Contributor

@jokd jokd commented Sep 23, 2024

Fixes #2049 and upgrades some other dependencies

@steff-o
Copy link
Contributor

steff-o commented Sep 27, 2024

Haven't tested yet, but if I remember correctly, there are some breaking changes that might affect us. Are you sure that no code changes are necessary?

@steff-o
Copy link
Contributor

steff-o commented Sep 30, 2024

Still haven't tested ...

Looks like breaking changes are few: https://github.com/openlayers/openlayers/blob/main/changelog/upgrade-notes.md

It was getFeaturesInExtent() in vector tiles I was uncertain about, but I can't find any direct references to getFeaturesInExtent() in our code but OL seems to use it internally in other calls as it is a part of the origo bundle. But I assume OL will be smart enough to figure out what to do when it is called internally when it is a VectorTile layer.

@Grammostola
Copy link
Contributor

Grammostola commented Sep 30, 2024

On a tangent ol/source/imageTile has appeared, so far with the intent of removing ol/source/tileImage if I interpret things correctly, (which may not be the case). Print uses ol/source/tileImage. So far so good in other words.

I aim to test this with a few different layer types and most controls during the day.

Edit. Looks good to me after some basic testing (geojson, wms and wfs layers, print, measure, the carousel in multiple overlay info hits).

@steff-o
Copy link
Contributor

steff-o commented Oct 2, 2024

Tested some basic stuff (WMS, WFS, Edit WFS incl. snapping, measure, print, featureInfo) in order to activate as much OL interactions as possible. Looks OK. Only concern is that OL 10.2.1 is out now... Just a minor bugfix regarding tiles.

I don't have any test setup for VectorTiles so I haven't tested that.

@jokd
Copy link
Contributor Author

jokd commented Oct 2, 2024

I changed to OL 10.2.1 and changed the version in package.json to 2.9.1-dev to show that this is a dev version of the upcoming release and not the latest release.

Copy link
Contributor

@steff-o steff-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some testing on searchList (awesomplete) and carousel (glide) as well as rerun tests for 10.2.1. Looks good.

@steff-o steff-o merged commit 12cf2a9 into origo-map:master Oct 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenLayers v10.2.0
3 participants