feature: add thematicStyling to sharemap

[dahlalex]

Fixes #issuenr 1951

[johnnyblasta]

Tested and works fine for GeoJSON and WFS (I assume, from the code, didn't test that), but it don't work for WMS.

[johnnyblasta]

One thought:

• The config part would be more simple if the label was used instead of constructing an array with zeros and ones.

[dahlalex]

I've made som changes to work also for WMS and found an issue that

origo.api().getStyles()[styleName][0].thematic[index].visible = false

has no effect.

It seems that this issue should be solved even if the label is used (if i understand correctly).

[johnnyblasta]

I've made som changes to work also for WMS and found an issue that

origo.api().getStyles()[styleName][0].thematic[index].visible = false

has no effect.

It seems that this issue should be solved even if the label is used (if i understand correctly).

ThematicStyling for WMS works by filtering the request, so I guess a new request has to be triggered.

[dahlalex]

Thanks for the helpful feedback! I've implemented your suggestion regarding the label, and it's working successfully even for WMS. You're absolutely right - using a label simplifies the configuration and eliminates the dependency on the specific order of zeros and ones in the array, which was definitely a downside. This approach makes the code more flexible and easier to maintain in the long run.

[Grammostola]

It appears to work for WMS now, nice : ) However the link uses rule titles rather than rule names (whereas getLegendGraphic for instance is forced to use rule names). Rule names are ids and titles are for humans so I think it would be better if it the link was saved with rule names.

Similarly for vector styles I thought an optional id prop for themes in a thematic style was a good idea since the same thing applies: labels are for human reading and can be long and colorful.

[dahlalex]

Excellent point! 😊 You're absolutely right about using rule names instead of titles for the WMS and theme IDs for vector styles. I've already made some changes and ensured both elements use IDs and names first, followed by labels where applicable. This creates a clearer distinction between human-readable labels and machine-readable identifiers.

[dahlalex]

In the shared link, I'm still unsure about the best separator to use between themes. I chose the tilde (~) because it's less common and therefore less likely to cause conflicts. What do you think? Do you have another suggestion that might be even better?

[Grammostola]

Cool, looks good now for WMS. For vector layers no themes are active when opening the shared map. I don't have an opinion on the separator, tilde is less common and this would likely do well described in the documentation somewhere too.

[dahlalex]

It works for me. Can you share the link you generate after clicking the "Share Map" button?

The issue might be due to vector styles lacking both IDs and labels. Adding either IDs or labels to these styles could potentially resolve the problem.

[Grammostola]

I used your example theme style for the origo cities layer and added an id prop to both. http://localhost:9966/#layers=osm/v/1/s/0/o/100,origo-mask/v/1/s/0/o/25,origo-cities/v/1/s/0/o/100/th/2&center=1810000,8390000&zoom=5.7&legend=expanded&map=index

...And the problem seems to be Number vs string. I gave the id prop a number value. Maybe both could be acceptable?

[dahlalex]

You're right! The number value for the id prop was causing the issue. Thanks for identifying this crucial detail. Converting it to a string seems to have corrected the problem.

[Grammostola]

Looks good to me. Tested with geojson, wfs and wms layers.