feature: rotate text and point in draw control #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good overall, nice feature! One note I have is the UI and "degrees rotation", if I pull the slider all the way to "-360°" (from the default 0) my cube rotates half a rotation, which seems appropriate function-wise but doesn't quite rhyme with the UI text. (And maybe "0" could be included?) |
|
Corrected the wrong degrees text and added a zero. |
|
Cheers. Hm, I've not seen a rotate control in the print preview but based on the opacity slider would it be easier to revert to the default value if the scale went from 0 (default) to 360? |
|
Sure, this makes it easier to get back to zero. |
|
Lgtm : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1941
Enables rotation for text and point in draw control.