fix: make draganddrop use existing style function for features withou…

[Grammostola]

…t a defined style. Seeks to fix #1935 . (The fix includes attempting to make kml files that from what I gather employ their own style not have the wrong legend. Yes it is a bonus, I was testing my proposed fix with different file formats. It can be removed.)

Creds to @jokd for the idea.

Edit. In contrast to merely extending the list of predefined featureStyles this solution will not provide a layer legend. However since featureStyles will take precedence one needs only to define these for the dragndrop control.

[johnnyblasta]

Tested with a KML and got a error.

Fixed it with this code with a check if geometry exists, on row 128 in draganddrop.js:

            if (feature.getGeometry() !== null) {
				const geometryType = feature.getGeometry().getType();
				if (featureStyles && featureStyles[geometryType]) {
				  if (!types.has(geometryType)) {
					styles.push(...featureStyles[geometryType]);
					types.add(geometryType);
				  }
				} else {
				  getStyleFunction(feature);
				}
            }

[Grammostola]

Cheers, I hadn't thought of adding a layer without geometry. What usage scenario are you thinking of? Feel free to push the proposed fix for that anyway.

[johnnyblasta]

Cheers, I hadn't thought of adding a layer without geometry. What usage scenario are you thinking of? Feel free to push the proposed fix for that anyway.

I had a KML which was exported from Autocad which apparently had some placemark without geometry. Don't know why that is, but would be nice if it can handle empty geometry without crashing.

[johnnyblasta]

@Grammostola made a commit in your branch.

[johnnyblasta]

LGTM

[Grammostola]

I had a KML which was exported from Autocad which apparently had some placemark without geometry. Don't know why that is, but would be nice if it can handle empty geometry without crashing.

Indeed, nice testing!