feature: new group options

[jokd]

Fixes #1896
Adds three new options for groups:

"description": "Group descripton", // If set, this is shown on second page along with opacityControl (if set)
"opacityControl": true, // If set, this is shown on second page along with description (if set). Changing the opacity will change the opacity for all layers in the group. It will also affect groups in the group.
"zoomToExtent": true, // If set to true and there is an extent set for the group a link in the popupMenu will be created

Example config:

{
      "name": "grupp",
      "title": "grupp",
      "expanded": true,
      "groups": [
        {
          "name": "grupp2",
          "title": "grupp2",
          "expanded": true,
          "abstract": "Kort abstract",
          "description": "Detta är en grupp för test, visas på sida 2",
          "opacityControl": true,
          "zoomToExtent": true,
          "extent": [
            -20026376.39,
            -20048966.10,
            20026376.39,
            20048966.10
          ]
        },{
          "name": "grupp3",
          "title": "grupp3"
        }
      ]
    }

[johnnyblasta]

Why only for subgroups?
Isn't there a case where you'd want this on a main group?

[johnnyblasta]

Tested and it works fine with the test cases I throw at it.

[jokd]

Why only for subgroups? Isn't there a case where you'd want this on a main group?

I thought subgroups are more similar to layers and could have this functionality but perhaps you are right and it should be possible. However I think groups are handled a bit different than subgroups but can have a look at it.

[johnnyblasta]

Why only for subgroups? Isn't there a case where you'd want this on a main group?

I thought subgroups are more similar to layers and could have this functionality but perhaps you are right and it should be possible. However I think groups are handled a bit different than subgroups but can have a look at it.

Yes, the handling is different and therefore I approved it after testing, but the user might not understand why it wouldn't be possible to set on main group also.

[jokd]

Why only for subgroups? Isn't there a case where you'd want this on a main group?

I thought subgroups are more similar to layers and could have this functionality but perhaps you are right and it should be possible. However I think groups are handled a bit different than subgroups but can have a look at it.

Yes, the handling is different and therefore I approved it after testing, but the user might not understand why it wouldn't be possible to set on main group also.

I had another go at it and now it will work on top level groups as well.
It will also fix #1640

[filleg]

Tried it with the latest changes and it works fine on the main group, but I can't get the moreinfo button to work on the subgroups.
Nice feature btw! Seems to cover #1492 as well.

[jokd]

Tried it with the latest changes and it works fine on the main group, but I can't get the moreinfo button to work on the subgroups. Nice feature btw! Seems to cover #1492 as well.

Had totally forgotten about that issue and it looks spot on this.
Whats your issue with subgroups?

[jokd]

Another thought; Perhaps the option to showAbstract shouldnt be about whether to show abstract on the properties-page as well as the legend but rather on properties page instead of the legend?
I bet @asemoller has opinons on this

[filleg]

Tried it with the latest changes and it works fine on the main group, but I can't get the moreinfo button to work on the subgroups. Nice feature btw! Seems to cover #1492 as well.

Had totally forgotten about that issue and it looks spot on this. Whats your issue with subgroups?

The moreinfo button works when only setting opacityControl:true, but nothing happens when I click if I also add zoomToExtent. Works well on the main group however.

[jokd]

Tried it with the latest changes and it works fine on the main group, but I can't get the moreinfo button to work on the subgroups. Nice feature btw! Seems to cover #1492 as well.

Had totally forgotten about that issue and it looks spot on this. Whats your issue with subgroups?

The moreinfo button works when only setting opacityControl:true, but nothing happens when I click if I also add zoomToExtent. Works well on the main group however.

Right on; might have messed up the popup when adding the group functionality. Will fix.

[asemoller]

You bet I do!

Abstract, description and showAbstract work fine. My only input is that the abstract/description is a bit confusing. Abstract's main position should be in the group info page just like it is for layers and not in the legend as it is now. If you want additional information that appears directly in the legend, it should be called description. So switching these two should be more user friendly for admins. But I understand if you don't want to make that change because backwards compatibility will be a bit damaged but I think it will be better in the end. As for showAbstract, I'm not convinced. Personally, I don't think that the same information should be shown in two places. But that's just me!

Really nice improvements!

[jokd]

OK new suggestion:
abstract and description are both to be found on the properties page, unless showAbstractInLegend is set to true and then it will behave like before. I suggest we default this to false so the abstract will move to the properties page unless configured to do so.

The reason for having both abstract and description as options is that some plugins/functions use abstract for adding layer information, the desciption option is a way to add another string.

[jokd]

Tried it with the latest changes and it works fine on the main group, but I can't get the moreinfo button to work on the subgroups. Nice feature btw! Seems to cover #1492 as well.

Had totally forgotten about that issue and it looks spot on this. Whats your issue with subgroups?

The moreinfo button works when only setting opacityControl:true, but nothing happens when I click if I also add zoomToExtent. Works well on the main group however.

Fixed now, managed to trigger click event twice

[johnnyblasta]

Tested again and still approve.
Good work!