Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no legend message #1873

Merged
merged 2 commits into from
Oct 27, 2023
Merged

fix: no legend message #1873

merged 2 commits into from
Oct 27, 2023

Conversation

Grammostola
Copy link
Contributor

Aims to fix #1858

@Grammostola
Copy link
Contributor Author

I was thinking two things here in order to more solidly fix the no legend message.
First, what with the recent PR to change "Legend" to "Teckenförklaring" in the Print control, the same reason should apply to the Legend control and the "No legend" message, no?

If so then
bild
which looks like the message did prior in that it is slightly clipped. Change the padding class or perhaps change the text size rather as the text seems a bit large at present. Making it slightly smaller makes it as large as the layer title. Therefore I propose making it slightly smaller still:
bild
This is currently what the pr looks like.

@Grammostola Grammostola changed the title fix: replicate prior elements for no legend message fix: no legend message Oct 25, 2023
Copy link
Contributor

@jokd jokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Grammostola Grammostola merged commit fd09146 into master Oct 27, 2023
4 checks passed
@Grammostola Grammostola deleted the nolegend_fix branch October 27, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draw legend is hiding text
2 participants