-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print - toggle between map and print layout interactions #1181
Print - toggle between map and print layout interactions #1181
Conversation
Here's a map for testing the behaviour: https://karta.haninge.se/devmaps/pr-print-map-vs-layout-interaction-toggle/ |
Nice work! The icon for the button is used in the editor for editing data, maybe it can be replaced with an map icon? Map on/off |
Agree with mulfvik, well done and using a map icon would probably be better. |
FYI the icon |
I suggest using the Material Icons map icon instead ( |
Based on a user suggestion, perhaps I should change the tooltip text to something less technical, e g "Ändra kartans läge" instead of "Aktivera kartvyn". What do you think? |
Sounds good! |
…ub.com/haninge-geodata/origo into print-map-vs-layout-interaction-toggle
Fixes #1157. Also part of #785.
o-print-tools-left
div section for print tools/buttons in the upper left.mapInteractionsActive
to set whether map interactions should be enabled by default (true) or not. Default is false.I'd happily take suggestions for the button icon (now using
#fa-pencil-square
).I made some changes to css classes to accommodate the new
o-print-tools-left
div and the extra button. I also removed the classwidth-20
from the print-settings.template.js which fixes an issue where the print settings collapsible was too wide for some mobile screens. It would be great of I could get some help with testing on different screens and devices though :)