#patch: Fixes #162 - Stable formatting between Jackson 2.16 and earli…

…er versions

Unfortunatily this reaches even deeper into Jackson internals than
before, so it might break in the future (again). On the other hand,
this sidesteps messing with reflection or other hacks to decide on which
version of Jackson we are currently running.

java-snapshot-testing-plugin-jackson/build.gradle

@@ -21,10 +21,10 @@ dependencies {
     testImplementation 'org.assertj:assertj-core:3.11.1'
     testImplementation 'org.skyscreamer:jsonassert:1.5.0' // For docs/ reporter example
 
-    testImplementation 'com.fasterxml.jackson.core:jackson-core:2.11.3'
-    testImplementation 'com.fasterxml.jackson.core:jackson-databind:2.11.3'
-    testRuntimeOnly 'com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.11.3'
-    testRuntimeOnly 'com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.11.3'
+    testImplementation 'com.fasterxml.jackson.core:jackson-core:2.16.0'
+    testImplementation 'com.fasterxml.jackson.core:jackson-databind:2.16.0'
+    testRuntimeOnly 'com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.16.0'
+    testRuntimeOnly 'com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.16.0'
 }
 
 test { useJUnitPlatform() }

java-snapshot-testing-plugin-jackson/src/main/java/au/com/origin/snapshots/jackson/serializers/v1/JacksonSnapshotSerializer.java

@@ -8,38 +8,14 @@
 import com.fasterxml.jackson.annotation.JsonAutoDetect;
 import com.fasterxml.jackson.annotation.JsonInclude;
 import com.fasterxml.jackson.core.PrettyPrinter;
-import com.fasterxml.jackson.core.util.DefaultIndenter;
-import com.fasterxml.jackson.core.util.DefaultPrettyPrinter;
-import com.fasterxml.jackson.core.util.Separators;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.SerializationFeature;
 import java.util.Arrays;
 import java.util.List;
 
 public class JacksonSnapshotSerializer implements SnapshotSerializer {
 
-  private final PrettyPrinter pp =
-      new DefaultPrettyPrinter("") {
-        {
-          Indenter lfOnlyIndenter = new DefaultIndenter("  ", "\n");
-          this.indentArraysWith(lfOnlyIndenter);
-          this.indentObjectsWith(lfOnlyIndenter);
-        }
-
-        // It's a requirement
-        // @see https://github.com/FasterXML/jackson-databind/issues/2203
-        public DefaultPrettyPrinter createInstance() {
-          return new DefaultPrettyPrinter(this);
-        }
-
-        @Override
-        public DefaultPrettyPrinter withSeparators(Separators separators) {
-          this._separators = separators;
-          this._objectFieldValueSeparatorWithSpaces =
-              separators.getObjectFieldValueSeparator() + " ";
-          return this;
-        }
-      };
+  private final PrettyPrinter pp = new SnapshotPrettyPrinter();
   private final ObjectMapper objectMapper =
       new ObjectMapper() {
         {

java-snapshot-testing-plugin-jackson/src/main/java/au/com/origin/snapshots/jackson/serializers/v1/SnapshotPrettyPrinter.java

@@ -0,0 +1,23 @@
+package au.com.origin.snapshots.jackson.serializers.v1;
+
+import com.fasterxml.jackson.core.util.DefaultIndenter;
+import com.fasterxml.jackson.core.util.DefaultPrettyPrinter;
+
+class SnapshotPrettyPrinter extends DefaultPrettyPrinter {
+
+  public SnapshotPrettyPrinter() {
+    super("");
+    Indenter lfOnlyIndenter = new DefaultIndenter("  ", "\n");
+    this.indentArraysWith(lfOnlyIndenter);
+    this.indentObjectsWith(lfOnlyIndenter);
+
+    this._objectFieldValueSeparatorWithSpaces =
+        this._separators.getObjectFieldValueSeparator() + " ";
+  }
+
+  // It's a requirement
+  // @see https://github.com/FasterXML/jackson-databind/issues/2203
+  public DefaultPrettyPrinter createInstance() {
+    return new DefaultPrettyPrinter(this);
+  }
+}