Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated SUPPORTED_PROTOCOL constant to 37 #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rrmerugu
Copy link

this shall possibly support orientdb 3.0.0

this shall possibly support orientdb 3.0.0
@rrmerugu
Copy link
Author

may be this shall call for version increment also !! in constants.py !

@rrmerugu
Copy link
Author

@Ostico are there any modifications needed for this codebase to support orientdb 3.0.0 !!

@OrientDBColin
Copy link

OrientDBColin commented Aug 6, 2018

Hi @rrmerugu,

Unfortunately, this solution won't work with OrientDB 3.0.3 and later.

It now adds a check to protocol 37 during the connect phase to see if a handshake were used.

It fails otherwise.

The simplest solution is to still use protocol 36 (OrientDB will adjust accordingly) until the handshake, etc. can be implemented and to comment out this in orient.py:

        if self.protocol > SUPPORTED_PROTOCOL:
            raise PyOrientWrongProtocolVersionException(
                "Protocol version " + str(self.protocol) +
                " is not supported yet by this client.", [])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants