[211] Added shuffling when drawing curses and blessings #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -191,6 +195,7 @@ var modifiersManagement = { | |||
| .filter(element => !this.modifiersDrawPile.includes(element)) | |||
|
|
|||
| if(availableCurses.length > 0) this.addModifier(availableCurses[0]) | |||
| this.shuffle(); | |||
| }, | |||
| resetModifiers: function() { | |||
| this.shuffleModifiersDeck() | |||
There was a problem hiding this comment.
Do you remember what the commented line below is about? Should we remove it or was it something important?
There was a problem hiding this comment.
Github doesnt show it in the preview, but line 202 is :
//this.modifiersDrawPile.forEach(card => {if(this.checkIfCurseOrBless(card)) this.removeModifier(card)})
There was a problem hiding this comment.
It was related to the changes I had to do when updating the cookie saving system. It implied a consequent refactoring of the curse/blessing system. I kept this line for legacy purposes only :)
RaphaelPage0110
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#211