Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-expansion deck saving issue #154

Open
RaphaelPage0110 opened this issue Feb 15, 2021 · 2 comments
Open

Multi-expansion deck saving issue #154

RaphaelPage0110 opened this issue Feb 15, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@RaphaelPage0110
Copy link
Collaborator

When saving a deck composed of cards from three classes from two different expansions, the cards of one of the classes isn't saved.
Steps to reproduce :

  1. Select 3 cards from the brute deck
  2. Select 3 cards from the tinkerer deck
  3. Switch expansion to JOTL
  4. Select 3 cards from the demolitionist deck
  5. Save
  6. Reload
    Expected : All the cards are present in the Play tab
    KO: Only the demolitionist cards are present
@RaphaelPage0110 RaphaelPage0110 added the bug Something isn't working label Feb 15, 2021
@orichalque
Copy link
Owner

its a cookie size issue i think

@orichalque
Copy link
Owner

instead of saving the full cards in cookie we could just keep the ID and fetch them from the database on loading

@orichalque orichalque changed the title Mutli-expansion deck saving issue Multi-expansion deck saving issue Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants