Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gear + Multiple Expansions #239

Open
kiwitrav opened this issue Jan 26, 2023 · 5 comments
Open

Gear + Multiple Expansions #239

kiwitrav opened this issue Jan 26, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@kiwitrav
Copy link
Contributor

Hi again, back with another low priority possible enhancement 😎

This is an easily worked-around QoL issue, by simply noting the gear you're using, switching to Vanilla and adding the gear pieces then switching back to the expansion, so very low priority.

Between plays if you need to refresh the page, but you're playing an expansion with vanilla (or any other expansion than your character) gear, it loses the gear.

My current specific example is Crimson Scales, while my char has mostly vanilla gear.

No idea if it's possible to save cross-expansion gear, but that would make things a little bit easier.

Thanks!

@orichalque
Copy link
Owner

That's a pretty tough one to implement :(. Atm when we load the gear, we only load the items that are from the defined expansion, and fetch the equipped item from it. We could instead load the items from the current expansion plus vanilla, byt that would make loading heavier.

@orichalque orichalque added the enhancement New feature or request label Jan 26, 2023
@orichalque
Copy link
Owner

that's related to #154

@kiwitrav
Copy link
Contributor Author

Thanks for considering it, and yes it looks very like 154, though this is more of a mainstream issue than mixing ability cards.

To get around this I'm wondering if the player data can be decoupled from the selected expansion - instead using expansion+id to load the individually-selected cards for the user while select expansion is more for the selection interface in the Ability and Gear screens (with the selected cards stored as part of the player data)

However that sounds like a lot of work to restructure things like that, so maybe don't bother 😁

@orichalque orichalque added bug Something isn't working and removed enhancement New feature or request labels Jan 27, 2023
@orichalque
Copy link
Owner

I added the bug label instead of enhancement, as this should be the normal behaviour :(

@orichalque
Copy link
Owner

instead using expansion+id
That would be easier indeed, but would represent a big change in the way we store items and abilities. Necessary though !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants