Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(fixtures): Ease testing just one fixture #374

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

Vaelatern
Copy link
Contributor

Description

$ ./test-fixtures.sh
[ok] test-duplicate-file-upload
[ok] test-expiring-file-upload
[ok] test-file-delete
[ok] test-file-upload
[ok] test-file-upload-override-filename
[ok] test-file-upload-same-filename
[ok] test-filename-replace
....
[ok] test-server-payload-limit
[ok] test-url-encode
[ok] test-url-upload
[ok] test-version-not-exposed
$

And it could be:

$ ./test-fixtures.sh
... everything from above without arguments....
$ ./test-fixtures.sh test-server-auth-multiple-tokens test-server-auth test-url-encode
[ok] test-server-auth-multiple-tokens
[ok] test-server-auth
[ok] test-url-encode
$

Motivation and Context

I was running tests for #373 and it was taking long enough to warrant a fix.

How Has This Been Tested?

Please see description for example run.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other: Tooling and developer joy.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

fixtures/test-fixtures.sh Outdated Show resolved Hide resolved
@Vaelatern Vaelatern force-pushed the ease-adding-new-fixtures branch from 2ca7c45 to c7f62a0 Compare December 6, 2024 02:01
@Vaelatern Vaelatern force-pushed the ease-adding-new-fixtures branch from c7f62a0 to b002da8 Compare December 6, 2024 02:06
Copy link
Collaborator

@tessus tessus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging with some nits :)

@orhun orhun merged commit 1bbc764 into orhun:master Dec 7, 2024
9 checks passed
@Vaelatern Vaelatern deleted the ease-adding-new-fixtures branch December 8, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants