Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server): remove shuttle code and deps #328

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

tessus
Copy link
Collaborator

@tessus tessus commented Aug 5, 2024

Description

This change removes the code for shuttle and also the gh workflow for shuttle deployment.

Motivation and Context

see #326

How Has This Been Tested?

  • cargo test
  • fixtures

Changelog Entry

### Removed

- shuttle code and deps

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tessus tessus requested a review from orhun as a code owner August 5, 2024 18:41
@orhun
Copy link
Owner

orhun commented Aug 6, 2024

We can also remove the shuttleapp.rs references from config.toml and examples/ :)

@tessus
Copy link
Collaborator Author

tessus commented Aug 6, 2024

Good point. Will do.

config.toml Show resolved Hide resolved
@orhun orhun merged commit ebe96cb into orhun:master Aug 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants