-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the category checked only if all the services are checked #732
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
✅ Deploy Preview for cookieconsentv3-playground canceled.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Seems like something useful. The behavior of the toggle button can be misleading. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@orestbida could you please take a look at this PR? |
The current toggle behaviour is the only one valid for me: whether you have accepted one or all tracking services, tracking is enabled nonetheless, so treat the category as enabled. Having an option to make it so that the category is on only when all its services are enabled would be way more misleading for the end user. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I have noticed that the category gets checked even if one of the services is checked, this seems strange to me as when you toggle the category all the services get toggled.
All the tests still pass.
A different approach that I would need some help implementing:
Add an option for the category logic with two options "AND" and "OR".
The "AND" option would mean that all services would need to be enabled for the category to be enabled.
The "OR" option would be if any service is enabled (how it currently works).