Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the category checked only if all the services are checked #732

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anthony0030
Copy link

@anthony0030 anthony0030 commented Sep 12, 2024

I have noticed that the category gets checked even if one of the services is checked, this seems strange to me as when you toggle the category all the services get toggled.

All the tests still pass.

A different approach that I would need some help implementing:
Add an option for the category logic with two options "AND" and "OR".
The "AND" option would mean that all services would need to be enabled for the category to be enabled.
The "OR" option would be if any service is enabled (how it currently works).

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
cookieconsent-docs ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:38am

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for cookieconsentv3-playground canceled.

Name Link
🔨 Latest commit 8e613c4
🔍 Latest deploy log https://app.netlify.com/sites/cookieconsentv3-playground/deploys/66e2b68a5768ad0008b1fa0c

Copy link

stale bot commented Oct 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 19, 2024
@theonlyriddle
Copy link

Seems like something useful. The behavior of the toggle button can be misleading.

@stale stale bot removed the stale label Oct 22, 2024
Copy link

stale bot commented Nov 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 23, 2024
@anthony0030
Copy link
Author

@orestbida could you please take a look at this PR?

@stale stale bot closed this Dec 3, 2024
@orestbida orestbida reopened this Dec 3, 2024
@stale stale bot removed the stale label Dec 3, 2024
@orestbida
Copy link
Owner

The current toggle behaviour is the only one valid for me: whether you have accepted one or all tracking services, tracking is enabled nonetheless, so treat the category as enabled.

Having an option to make it so that the category is on only when all its services are enabled would be way more misleading for the end user.

Copy link

stale bot commented Jan 3, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants