Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation #566

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tmieslinger
Copy link
Contributor

This PR adds a notebook showing basic usage of the flight segmentation.
As this requires access to HALO flight track data, which is the first use of IPFS in this repo, it also initializes an IPFS node in the CI.

@tmieslinger tmieslinger requested a review from lkluft December 5, 2024 09:32
@lkluft lkluft linked an issue Dec 5, 2024 that may be closed by this pull request
Copy link
Contributor

@lkluft lkluft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! (And also for adding IPFS to the CI).

It seems that the execution of the notebook timed out during the build. Do you know how long the notebook usually runs on your machine? We need to find out if it is just slow in general (then we could increase the timeout period) or if the IPFS node cannot find the CIDs in time (not so easy to solve)

Comment on lines +75 to +76
touch ipfs.log # ensure the file exists such that `tail` doesn't fail.
ipfs daemon 2>ipfs.log | grep -i -o -m1 'Daemon is ready' & tail -f --pid=$! ipfs.log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use -F instead of -f:

If the file being followed does not (yet) exist or if it is removed, tail will keep looking and will display the file from the beginning if and when it is created.

Suggested change
touch ipfs.log # ensure the file exists such that `tail` doesn't fail.
ipfs daemon 2>ipfs.log | grep -i -o -m1 'Daemon is ready' & tail -f --pid=$! ipfs.log
ipfs daemon 2>ipfs.log | grep -i -o -m1 'Daemon is ready' & tail -F --pid=$! ipfs.log

@lkluft
Copy link
Contributor

lkluft commented Dec 5, 2024

I tried to build the book locally, but it currently fails with

FileNotFoundError: https://orcestra-campaign.github.io/flight_segmentation/all_flights.yaml

which is likely caused by a failed CI job in the flight segmentation repo 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure IPFS node for Github CI/CD
2 participants