Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit startpage #41

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Edit startpage #41

merged 6 commits into from
Jul 22, 2024

Conversation

yu71ng
Copy link
Contributor

@yu71ng yu71ng commented Jul 4, 2024

No description provided.

Copy link
Collaborator

@d70-t d70-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the start page ❤️👍

Currently we have a copy of a lot of the information of intro.md in orcestra.md as well, so if we change the wording here, this change should likely also go into the other document.
A (likely better) alternative to co-updating both files all the time would be to re-design intro.md and orcestra.md such that we don't duplicate information between the two files and thus could continue developing them independently.
This re-design could easily be part of another PR, but in that case, I'd recommend to update orcestra.md such that it follows intro.md for the time being.

orcestra_book/intro.md Outdated Show resolved Hide resolved
orcestra_book/intro.md Outdated Show resolved Hide resolved
@yu71ng
Copy link
Contributor Author

yu71ng commented Jul 5, 2024

Certainly!

Yes, I was thinking of re-design both pages in a less repetitive way and will edit orcestra.md later on.

Since intro.md is the start page I wanted to work on it first before editing orcestra.md.

@d70-t
Copy link
Collaborator

d70-t commented Jul 5, 2024

Great!
So does this mean that we keep the PR open, until you've applied the changes to the Overview as well?

@yu71ng
Copy link
Contributor Author

yu71ng commented Jul 5, 2024

Let's keep the PR open until I made the other changes. Then we can do in one go. :)

@yu71ng
Copy link
Contributor Author

yu71ng commented Jul 18, 2024

With the new commit #42 was considered. The logos were added in the page of orcestra.md.

@yu71ng yu71ng requested a review from d70-t July 22, 2024 08:58
Copy link
Collaborator

@d70-t d70-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the nice redesign of the start page!

I've placed a few minor comments which should be easy to resolve.
Apart from that, there's currently a merge conflict with main, such that I'd recommend to rebase this PR on the current main and to use this as an opportunity to integrate the suggested fixes.

orcestra_book/_config.yml Outdated Show resolved Hide resolved
config:
bibtex_default_style: myapastyle
bibtex_reference_style: author_year_round
html_theme_options:
show_prev_next: false
# panels_add_bootstrap_css: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is just a comment and likely accidental.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It was during my previous tryouts. This change can be removed.

orcestra_book/orcestra.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@d70-t d70-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome 👍

@d70-t d70-t merged commit 8b2bb5b into orcestra-campaign:main Jul 22, 2024
2 checks passed
@yu71ng yu71ng deleted the edit_startpage branch July 22, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants