-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit startpage #41
Edit startpage #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the start page ❤️👍
Currently we have a copy of a lot of the information of intro.md
in orcestra.md
as well, so if we change the wording here, this change should likely also go into the other document.
A (likely better) alternative to co-updating both files all the time would be to re-design intro.md
and orcestra.md
such that we don't duplicate information between the two files and thus could continue developing them independently.
This re-design could easily be part of another PR, but in that case, I'd recommend to update orcestra.md
such that it follows intro.md
for the time being.
Certainly! Yes, I was thinking of re-design both pages in a less repetitive way and will edit orcestra.md later on. Since intro.md is the start page I wanted to work on it first before editing orcestra.md. |
Great! |
Let's keep the PR open until I made the other changes. Then we can do in one go. :) |
With the new commit #42 was considered. The logos were added in the page of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the nice redesign of the start page!
I've placed a few minor comments which should be easy to resolve.
Apart from that, there's currently a merge conflict with main
, such that I'd recommend to rebase this PR on the current main and to use this as an opportunity to integrate the suggested fixes.
orcestra_book/_config.yml
Outdated
config: | ||
bibtex_default_style: myapastyle | ||
bibtex_reference_style: author_year_round | ||
html_theme_options: | ||
show_prev_next: false | ||
# panels_add_bootstrap_css: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is just a comment and likely accidental.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It was during my previous tryouts. This change can be removed.
Co-authored-by: Tobias Kölling <[email protected]>
Startpage was updated accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome 👍
No description provided.