Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bibtex references #3

Merged
merged 2 commits into from
Dec 14, 2023
Merged

bibtex references #3

merged 2 commits into from
Dec 14, 2023

Conversation

d70-t
Copy link
Collaborator

@d70-t d70-t commented Dec 13, 2023

This PR enables reasonably formatted citations and adds a references section.

@d70-t d70-t requested a review from tmieslinger December 13, 2023 22:31
@tmieslinger
Copy link
Contributor

Thanks for adding the references! That will be of great help especially in the Science section :)
Currently, the References is the last page of the book and it's the only one with a slight change in the page layout (see attachement) where the footer is moved to the right. Do you know why that happens?

Screenshot 2023-12-14 at 11 07 02

Other than that I am super happy about the setup. I also checked it with two or more authors and it works as expected :)

@d70-t
Copy link
Collaborator Author

d70-t commented Dec 14, 2023

Apparently, the tool which generates the references adds an additional closing </div> to the generated HTML output, which completely screws up the remaining part of the page. I'll have to dig a little deeper to find where this comes from exactly.

Currently content after the references section would be broken.

see: jupyter-book/jupyter-book#1997
@d70-t d70-t merged commit 40c64d8 into main Dec 14, 2023
4 checks passed
@d70-t d70-t deleted the references branch December 14, 2023 11:25
lkluft pushed a commit to lkluft/orcestra-campaign-book that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants