Make density open in a separate tab

[dthaler]

Addresses more of #217

Summary by CodeRabbit

• User Interface
  • Improved navigation buttons by converting them to clickable links
  • Links now open in new tabs, allowing users to keep the current page open while accessing additional information

[coderabbitai]

Walkthrough

The pull request introduces modifications to the NodeEvents.cshtml page, specifically focusing on navigation button implementation. Two <button> elements have been transformed into <a> elements, enabling direct hyperlink navigation to the Spectral Density page. The changes implement a more standard web navigation approach by adding href attributes and target="_blank" to ensure links open in new browser tabs.

Changes

File	Change Summary
OrcanodeMonitor/Pages/NodeEvents.cshtml	Replaced <button> elements with <a> hyperlinks for Spectral Density page navigation

Poem

🐰 Hop, hop, through the web we go!
Buttons to links, a navigational flow
New tabs unfurl with a gentle click
Spectral Density's path, smooth and slick
A rabbit's guide to user delight 🌐

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

OrcanodeMonitor/Pages/NodeEvents.cshtml (3)

11-13: Add security attribute for target="_blank"

The conversion to an anchor tag with target="_blank" is good, but consider adding rel="noopener" to prevent potential security vulnerabilities in older browsers.

-    <a href="@Url.Page("/SpectralDensity", new { id = Model.Id })" class="btn btn-primary" target="_blank">
+    <a href="@Url.Page("/SpectralDensity", new { id = Model.Id })" class="btn btn-primary" target="_blank" rel="noopener">

---

77-79: Improve consistency and security

Two suggestions for improvement:

1. Consider using consistent button styling classes between the top button (btn-primary) and this one (selected).
2. Add rel="noopener" for security when using target="_blank".

-                        <a href="@Url.Page("/SpectralDensity", new { id = item.ID })" class="btn selected" style="@Model.GetEventButtonStyle(item)" target="_blank">
+                        <a href="@Url.Page("/SpectralDensity", new { id = item.ID })" class="btn btn-primary" style="@Model.GetEventButtonStyle(item)" target="_blank" rel="noopener">

---

11-13: Enhance accessibility for screen readers

Consider adding screen reader context to indicate that these links open in new tabs.

-    <a href="@Url.Page("/SpectralDensity", new { id = Model.Id })" class="btn btn-primary" target="_blank">
+    <a href="@Url.Page("/SpectralDensity", new { id = Model.Id })" class="btn btn-primary" target="_blank" rel="noopener">
         View Most Recent Spectral Density
+        <span class="visually-hidden">(opens in new tab)</span>

Apply similar changes to the second link as well.

Also applies to: 77-79

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 35edd45 and a8a75d1.

📒 Files selected for processing (1)

• OrcanodeMonitor/Pages/NodeEvents.cshtml (2 hunks)