Mark stream as offline if manifest file doesn't exist

[dthaler]

Fixes #226

Summary by CodeRabbit

• New Features

  • Enhanced error handling for audio stream availability, improving node state tracking.
  • Updated logic for audio stream status to ensure accurate representation based on valid frequency information.

• Bug Fixes

  • Refined state management for nodes in relation to audio stream processing.

[coderabbitai]

Walkthrough

The pull request modifies the Fetcher class in the OrcanodeMonitor.Core namespace, focusing on improving error handling and state management for audio stream processing. The changes primarily affect two methods: GetLatestAudioSampleAsync and UpdateManifestTimestampAsync. The modifications enhance how the system tracks and updates node status when encountering issues with audio sample retrieval, particularly when the HTTP response is unsuccessful or manifest information is unavailable.

Changes

File	Change Summary
OrcanodeMonitor/Core/Fetcher.cs	- Modified GetLatestAudioSampleAsync to update node properties when HTTP response is unsuccessful - Updated UpdateManifestTimestampAsync to conditionally update audio stream status based on frequency information

Assessment against linked issues

Objective	Addressed	Explanation
Status should go down when no S3 manifest found [#226]	✅

Possibly related PRs

• Improvements to node specific page #221: Modifications to GetLatestAudioSampleAsync and UpdateManifestTimestampAsync methods in the Fetcher class

Poem

🐰 In the realm of bytes and streams so bright,
A fetcher's dance of error's might,
Nodes now whisper their true state clear,
When manifests hide and samples disappear,
Code hops forward with rabbit delight! 🎵

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

OrcanodeMonitor/Core/Fetcher.cs (1)

978-980: Fix indentation for better readability.

The indentation of line 980 is inconsistent with the surrounding code.

Apply this diff to fix the indentation:

            if (frequencyInfo != null)
            {
-                node.AudioStreamStatus = frequencyInfo.Status;
+               node.AudioStreamStatus = frequencyInfo.Status;
            }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a65d7a and e237e6f.

📒 Files selected for processing (1)

• OrcanodeMonitor/Core/Fetcher.cs (2 hunks)

🔇 Additional comments (1)

OrcanodeMonitor/Core/Fetcher.cs (1)

911-918: LGTM! Implementation aligns with PR objective.

The changes correctly implement the requirement to mark a stream as offline when its manifest file doesn't exist. Setting ManifestUpdatedUtc to DateTime.MinValue ensures the stream will appear as offline since it will be older than MaxUploadDelay.