Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust m3u8 target duration #5

Merged
merged 8 commits into from
Nov 16, 2022

Conversation

valentina-s
Copy link
Contributor

This PR modifies the calculation of target_duration. It is 11 in the m3u8 files, while the files are about 10 sec long. So instead the target duration is calculated as average of all files in the folder. This change pulls the files as expected.

@EveningShower
Copy link

EveningShower commented May 3, 2022

Hey @valentina-s, I have been trying to use this branch to pull some files, I used your notebook from issue #3 as guidance, but it doesn't give me the same results, I tried with multiple timestamps but it always gives the same error as shown in this notebook.
It pulls all the files correctly but after finishing it encounters some kind of problem that involves the overwrite_output argument, but I don't understand why that would be a problem.
Any idea what's causing this? Does it work well for you?

@valentina-s valentina-s merged commit cda6871 into orcasound:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants