Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update doc for ReferrerListPageSize #842

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

Wwwsylvia
Copy link
Member

Resolves: #841

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.67%. Comparing base (5602bbd) to head (1bf7e79).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
- Coverage   77.91%   75.67%   -2.24%     
==========================================
  Files          63       63              
  Lines        4699     6011    +1312     
==========================================
+ Hits         3661     4549     +888     
- Misses        657     1080     +423     
- Partials      381      382       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to mention the legacy oras artifact spec?

@Wwwsylvia
Copy link
Member Author

Do you want to mention the legacy oras artifact spec?

@shizhMSFT I concerned that might introduce confusion as the ORAS artifact spec has been deprecated and users don't need to know it. But maybe I can mention the related issue.

Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit bf570bc into oras-project:main Nov 8, 2024
9 checks passed
@Wwwsylvia Wwwsylvia deleted the doc_referrers_page branch November 8, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository.ReferrersListPageSize may not work for all registries
2 participants