-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support context cancellation in file store #803
feat: support context cancellation in file store #803
Conversation
Signed-off-by: Lucas Rodriguez <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
==========================================
+ Coverage 77.88% 77.94% +0.06%
==========================================
Files 63 63
Lines 4694 4698 +4
==========================================
+ Hits 3656 3662 +6
+ Misses 657 656 -1
+ Partials 381 380 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucasrod16 Thank you for the contribution! Code changes LGTM.
Can we add some unit tests and make sure the diff coverage reaches 80%?
Signed-off-by: Lucas Rodriguez <[email protected]>
@Wwwsylvia Yes! I added a unit test for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #619