Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support context cancellation in file store #803

Conversation

lucasrod16
Copy link
Contributor

Closes #619

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.94%. Comparing base (d9e1d43) to head (66bf5e9).
Report is 1 commits behind head on main.

Files Patch % Lines
content/file/file.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
+ Coverage   77.88%   77.94%   +0.06%     
==========================================
  Files          63       63              
  Lines        4694     4698       +4     
==========================================
+ Hits         3656     3662       +6     
+ Misses        657      656       -1     
+ Partials      381      380       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasrod16 Thank you for the contribution! Code changes LGTM.
Can we add some unit tests and make sure the diff coverage reaches 80%?

Signed-off-by: Lucas Rodriguez <[email protected]>
@lucasrod16
Copy link
Contributor Author

lucasrod16 commented Aug 16, 2024

@lucasrod16 Thank you for the contribution! Code changes LGTM. Can we add some unit tests and make sure the diff coverage reaches 80%?

@Wwwsylvia Yes! I added a unit test for tarDirectory. I tried to verify the coverage locally with codecov-cli but ran into errors about requiring a token for uploading the report

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 606f636 into oras-project:main Aug 20, 2024
9 checks passed
@lucasrod16 lucasrod16 deleted the 619-support-context-cancel-in-file-store branch August 20, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File store to support context cancel
3 participants