fix: check empty registry name #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shizhMSFT
requested review from
sajayantony,
SteveLasker and
Wwwsylvia
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
=======================================
Coverage 75.62% 75.62%
=======================================
Files 63 63
Lines 5981 5981
=======================================
Hits 4523 4523
Misses 1076 1076
Partials 382 382 ☔ View full report in Codecov by Sentry. |
|
LGTM although IANAM |
Signed-off-by: Shiwei Zhang <[email protected]>
shizhMSFT
force-pushed
the
fix_ref_empty_domain
branch
from
65b4359 to
b94b39b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #698