Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: modernize registry interface #92

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

shizhMSFT
Copy link
Contributor

What this PR does / why we need it

Refine the interface of registry to match modern dotnet / C# features.

Which issue(s) this PR resolves / fixes

Resolve partially #91

Please check the following list

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 105 lines in your changes are missing coverage. Please review.

Comparison is base (0b2672f) 71.81% compared to head (491693f) 72.35%.

Files Patch % Lines
src/OrasProject.Oras/Registry/Remote/Repository.cs 79.59% 32 Missing and 8 partials ⚠️
.../OrasProject.Oras/Registry/Remote/ManifestStore.cs 78.39% 25 Missing and 10 partials ⚠️
src/OrasProject.Oras/Registry/Remote/BlobStore.cs 70.70% 19 Missing and 10 partials ⚠️
src/OrasProject.Oras/Registry/Remote/Registry.cs 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   71.81%   72.35%   +0.54%     
==========================================
  Files          33       35       +2     
  Lines        1004     1013       +9     
  Branches       88       93       +5     
==========================================
+ Hits          721      733      +12     
+ Misses        232      229       -3     
  Partials       51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shizhMSFT shizhMSFT mentioned this pull request Jan 2, 2024
6 tasks
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 538d214 into oras-project:main Jan 2, 2024
7 checks passed
@shizhMSFT shizhMSFT deleted the refactor_registry branch January 10, 2024 03:11
@shizhMSFT shizhMSFT mentioned this pull request Jan 15, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants