Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add license checker and missing license headers #86

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

shizhMSFT
Copy link
Contributor

What this PR does / why we need it

Important

The licenses of dependencies are not checked since SkyWalking-Eyes does not support dotnet projects.

Add a license checker and add missing license headers.

Which issue(s) this PR resolves / fixes

Resolves #61

Please check the following list

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9650855) 73.07% compared to head (45a0fa2) 73.07%.

Files Patch % Lines
src/OrasProject.Oras/Remote/Registry.cs 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   73.07%   73.07%           
=======================================
  Files          31       31           
  Lines        1040     1040           
  Branches       91       91           
=======================================
  Hits          760      760           
  Misses        228      228           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 5ad6ab9 into oras-project:main Dec 27, 2023
3 checks passed
@shizhMSFT shizhMSFT deleted the check_license branch January 2, 2024 03:28
@shizhMSFT shizhMSFT mentioned this pull request Jan 15, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add license checker
3 participants