Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repository): mounting support #152

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

leonardochaia
Copy link
Contributor

@leonardochaia leonardochaia commented Nov 11, 2024

What this PR does / why we need it

This PR adds blob mounting support to the IRepository and its Repository implementation.

Which issue(s) this PR resolves / fixes

Resolves / Fixes #<issue_id>

Please check the following list

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 91.37931% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.70%. Comparing base (6d94929) to head (233e79d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/OrasProject.Oras/Registry/Remote/BlobStore.cs 91.22% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   81.03%   81.70%   +0.66%     
==========================================
  Files          35       35              
  Lines        1060     1104      +44     
  Branches      123      128       +5     
==========================================
+ Hits          859      902      +43     
  Misses        146      146              
- Partials       55       56       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Here's my code review.

src/OrasProject.Oras/Registry/IMounter.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/Repository.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/Repository.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/BlobStore.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/BlobStore.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/BlobStore.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/BlobStore.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

src/OrasProject.Oras/Registry/Remote/Repository.cs Outdated Show resolved Hide resolved
@Wwwsylvia
Copy link
Member

Thanks. This can now be linked to #153.

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

src/OrasProject.Oras/Registry/Remote/BlobStore.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leonardochaia and others added 4 commits November 13, 2024 10:31
Co-authored-by: Shiwei Zhang <[email protected]>
Signed-off-by: Leonardo Chaia <[email protected]>
Signed-off-by: Leonardo Chaia <[email protected]>
@shizhMSFT shizhMSFT force-pushed the feat/repository-mounting branch from a2c1758 to 233e79d Compare November 13, 2024 02:31
@shizhMSFT shizhMSFT merged commit e1d8dc6 into oras-project:main Nov 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants