Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Pack Manifests #149

Merged
merged 15 commits into from
Nov 12, 2024

Conversation

nhu1997
Copy link
Contributor

@nhu1997 nhu1997 commented Oct 17, 2024

What this PR does / why we need it

There are use cases where .net sdk is needed to support attaching annotations such as End of Life.

Which issue(s) this PR resolves / fixes

Pack Manifests · Issue #39 · oras-project/oras-dotnet (github.com)

Please check the following list

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@sajayantony
Copy link
Contributor

@nhu1997 could you fix the DCO errors?

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 84.17722% with 25 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (f33af92) to head (ca03e9e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
....Oras/Exceptions/InvalidDateTimeFormatException.cs 0.00% 9 Missing ⚠️
...oject.Oras/Exceptions/InvalidMediaTypeException.cs 33.33% 6 Missing ⚠️
...ct.Oras/Exceptions/MissingArtifactTypeException.cs 33.33% 6 Missing ⚠️
src/OrasProject.Oras/Packer.cs 97.24% 2 Missing and 1 partial ⚠️
src/OrasProject.Oras/PackManifestOptions.cs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   80.48%   81.03%   +0.54%     
==========================================
  Files          30       35       +5     
  Lines         902     1060     +158     
  Branches      109      123      +14     
==========================================
+ Hits          726      859     +133     
- Misses        122      146      +24     
- Partials       54       55       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nhu1997 nhu1997 force-pushed the users/lihhu/issue39 branch from 7af3509 to 92f6a50 Compare October 18, 2024 03:12
src/OrasProject.Oras/Exceptions/InvalidPackException.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
@nhu1997 nhu1997 force-pushed the users/lihhu/issue39 branch from 0994539 to 3a815f7 Compare October 22, 2024 20:34
@nhu1997 nhu1997 requested a review from shizhMSFT October 23, 2024 23:07
Signed-off-by: nhu1997 <[email protected]>
src/OrasProject.Oras/Oci/Descriptor.cs Show resolved Hide resolved
src/OrasProject.Oras/Oci/Descriptor.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Oci/Descriptor.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Oci/MediaType.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/PackManifestOptions.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Oci/Descriptor.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Oci/Descriptor.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Pack.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/UnknownMediaType.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Oci/Descriptor.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/PackManifestOptions.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Oci/Descriptor.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Oci/Descriptor.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Utils/MediaType.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 6d94929 into oras-project:main Nov 12, 2024
7 checks passed
@shizhMSFT shizhMSFT mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants