fix: use the correct header collection for Docker-Content-Digest #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While testing against https://hub.docker.com/_/registry, "Docker-Content-Digest" headers were found on response.Headers collection rather than response.Content.Headers. Aligned internal/private variables to use _camelCase as there was some inconsistencies. Signed-off-by: Daniel Robinson <[email protected]>
daniel-pebble
requested review from
sammychinedu2ky,
shizhMSFT and
Wwwsylvia
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
=======================================
Coverage 80.15% 80.15%
=======================================
Files 30 30
Lines 897 897
Branches 108 108
=======================================
Hits 719 719
Misses 124 124
Partials 54 54 ☔ View full report in Codecov by Sentry. |
shizhMSFT
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
LGTM. Thank @daniel-pebble for your contribution.
We are not able to merge this PR since it does not have sufficient unit test code coverage due to the change of "Aligned internal/private variables to use _camelCase as there was some inconsistencies".
Could you add the related unit tests, or split this PR into two PRs (one to fix the header, and another to fix the _camelCase with unit tests)?
shizhMSFT
changed the title
4 tasks
|
Closing, will resolve under #136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
While testing against https://hub.docker.com/_/registry, "Docker-Content-Digest" headers were found on response.Headers collection rather than response.Content.Headers. Aligned internal/private variables to use _camelCase as there was some inconsistencies.
Which issue(s) this PR resolves / fixes
Resolves / Fixes #133 .
Please check the following list