-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RV-238: Update padding styles of Card Table, List Table to updated OXD standards #823
Merged
Super-Chama
merged 30 commits into
orangehrm:ent
from
thinithi-dil:rv-238-new-ui-ux-standards
Dec 10, 2024
Merged
RV-238: Update padding styles of Card Table, List Table to updated OXD standards #823
Super-Chama
merged 30 commits into
orangehrm:ent
from
thinithi-dil:rv-238-new-ui-ux-standards
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super-Chama
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When submitting PR to review
- Provide appropriate title with ticket ID
- Check the checklist and make sure the items are covered
- Update
changelog.md
to reflect your change - Make sure to link your official mail to github account as it will be used to commit
- Peer reviews, architect review ? good at least someone from the team checks and approves with a comment.
thinithi-dil
changed the title
Rv 238 new UI ux standards
RV-238: Apply new UI/UX standards regarding padding to Card Table, List and List Table
Dec 2, 2024
Hi @Super-Chama , review has done from my end. Seems good. |
Super-Chama
reviewed
Dec 10, 2024
Super-Chama
reviewed
Dec 10, 2024
components/src/core/components/ListTable/__tests__/list-table.spec.ts
Outdated
Show resolved
Hide resolved
Super-Chama
reviewed
Dec 10, 2024
components/src/core/components/ListTable/__tests__/list-table.spec.ts
Outdated
Show resolved
Hide resolved
Super-Chama
reviewed
Dec 10, 2024
components/src/core/components/ListTable/__tests__/list-table.spec.ts
Outdated
Show resolved
Hide resolved
Super-Chama
reviewed
Dec 10, 2024
components/src/core/components/ListTable/__tests__/list-table.spec.ts
Outdated
Show resolved
Hide resolved
Super-Chama
reviewed
Dec 10, 2024
components/src/core/components/ListTable/__tests__/list-table.spec.ts
Outdated
Show resolved
Hide resolved
Super-Chama
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some additional comments. please fix them and update.
Super-Chama
changed the title
RV-238: Apply new UI/UX standards regarding padding to Card Table, List and List Table
RV-238: Update padding styles of Card Table, List Table to updated OXD standards
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist