Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RV-238: Update padding styles of Card Table, List Table to updated OXD standards #823

Merged
merged 30 commits into from
Dec 10, 2024

Conversation

thinithi-dil
Copy link

@thinithi-dil thinithi-dil commented Nov 28, 2024

Checklist

  • Test Coverage is 100% for the newly added code
  • Storybook stories are added/updated for the changed areas
  • Components standards defined in this document are followed
  • Code is linted properly
  • Developer testing is done for the affected areas
  • Package version updated (not applicable to ent branch)
  • Changelog.md updated on possible breaking (applicable to ent branch)

Copy link
Member

@Super-Chama Super-Chama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When submitting PR to review

  1. Provide appropriate title with ticket ID
  2. Check the checklist and make sure the items are covered
  3. Update changelog.md to reflect your change
  4. Make sure to link your official mail to github account as it will be used to commit
  5. Peer reviews, architect review ? good at least someone from the team checks and approves with a comment.

@thinithi-dil thinithi-dil changed the title Rv 238 new UI ux standards RV-238: Apply new UI/UX standards regarding padding to Card Table, List and List Table Dec 2, 2024
@ShachiniMekala
Copy link

Hi @Super-Chama , review has done from my end. Seems good.

changelog.md Outdated Show resolved Hide resolved
Copy link
Member

@Super-Chama Super-Chama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some additional comments. please fix them and update.

@Super-Chama Super-Chama changed the title RV-238: Apply new UI/UX standards regarding padding to Card Table, List and List Table RV-238: Update padding styles of Card Table, List Table to updated OXD standards Dec 10, 2024
@Super-Chama Super-Chama merged commit a7ee333 into orangehrm:ent Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants