Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RV-146: Add persistent behaviour to OXD PopOver, Stop closing OXD Dialog when Esc key pressed #818

Merged
merged 4 commits into from
Nov 13, 2024
Merged

RV-146: Add persistent behaviour to OXD PopOver, Stop closing OXD Dialog when Esc key pressed #818

merged 4 commits into from
Nov 13, 2024

Conversation

inmoh7
Copy link

@inmoh7 inmoh7 commented Nov 8, 2024

Checklist

  • Test Coverage is 100% for the newly added code
  • Storybook stories are added/updated for the changed areas
  • Components standards defined in this document are followed
  • Code is linted properly
  • Developer testing is done for the affected areas
  • Package version updated (not applicable to ent branch)
  • Changelog.md updated on possible breaking (applicable to ent branch)

@inmoh7 inmoh7 changed the title Modified PopOver as configurable to persistent or not RV-146 : Modified PopOver as configurable to persistent or not Nov 8, 2024
@Super-Chama Super-Chama changed the title RV-146 : Modified PopOver as configurable to persistent or not RV-146: Add persistent behaviour to OXD PopOver, Stop closing OXD Dialog when Esc key pressed Nov 8, 2024
@inmoh7 inmoh7 force-pushed the modal-close-behavior branch from 188af7b to d967f89 Compare November 13, 2024 08:14
@inmoh7 inmoh7 force-pushed the modal-close-behavior branch from 3eb05ed to bdd65a0 Compare November 13, 2024 08:21
@Super-Chama Super-Chama merged commit 86d8e1b into orangehrm:ent Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Super-Chama Super-Chama Super-Chama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inmoh7 @Super-Chama