Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-808: Add custom handler functions support to OXD profile pic & link cell types #798

Merged
merged 9 commits into from
Nov 4, 2024
Merged

ENG-808: Add custom handler functions support to OXD profile pic & link cell types #798

merged 9 commits into from
Nov 4, 2024

Conversation

DanuAnjana
Copy link

@DanuAnjana DanuAnjana commented Oct 11, 2024 •
edited
Loading

Checklist

  • Test Coverage is 100% for the newly added code
  • Storybook stories are added/updated for the changed areas
  • Components standards defined in this document are followed
  • Code is linted properly
  • Developer testing is done for the affected areas
  • Package version updated (not applicable to ent branch)
  • Changelog.md updated on possible breaking (applicable to ent branch)

@DanuAnjana DanuAnjana changed the title eng-808 - add onclick event to prevent default behaviour of link and execute a function ENG-808: add an onClick event to the link inside the LinkWithPill and ProfilePic components to prevent the default link behavior and trigger a custom function Oct 29, 2024
Super-Chama
Super-Chama reviewed Oct 31, 2024
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
Super-Chama
Super-Chama requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@Super-Chama Super-Chama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are unrelated old commits here. best to rebase from upstream/ent

@Super-Chama Super-Chama changed the title ENG-808: add an onClick event to the link inside the LinkWithPill and ProfilePic components to prevent the default link behavior and trigger a custom function ENG-808: Add custom handler functions support to OXD profile pic & link cell types Oct 31, 2024
@DanuAnjana
LinkWithPill.vue, link-with-pill.spec.ts, ProfilePicture.vue, Profile…
406ec28 
…Pic.vue, profile-pic.spec.ts, ListSkeleton.story.vue - add onclick event to prevent default behaviour of link and execute a function
@DanuAnjana
ProfilePicture.vue, ProfilePic.vue, profile-pic.spec.ts- add onclick …
1f12a2e 
…event to prevent default behaviour of link and execute a function
@DanuAnjana
indentation correct from lint command
e34266b
@DanuAnjana
Icons.ts - add external link icon
e491e39
@DanuAnjana
add log details
2f72fbe
@DanuAnjana
ProfilePicture.vue, ProfilePic.vue, profile-pic.spec.ts- add onclick …
b7481d6 
…event to prevent default behaviour of link and execute a function fix issue
@DanuAnjana
add log details
b486c32
@DanuAnjana
remove unused code
cd0abf9
@Super-Chama Super-Chama merged commit 4268528 into orangehrm:ent Nov 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Super-Chama Super-Chama Super-Chama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanuAnjana @Super-Chama