Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ccs autocomplete show all items #740

Closed
wants to merge 3 commits into from
Closed

Feature/ccs autocomplete show all items #740

wants to merge 3 commits into from

Conversation

udithaOHRM
Copy link

@udithaOHRM udithaOHRM commented Nov 17, 2023 •
edited
Loading

Checklist

  • Test Coverage is 100% for the newly added code
  • Storybook stories are added/updated for the changed areas
  • Components standards defined in this document are followed
  • Code is linted properly
  • Developer testing is done for the affected areas
  • Package version updated (not applicable to ent branch)
  • Changelog.md updated on possible breaking (applicable to ent branch)

Super-Chama
Super-Chama requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@Super-Chama Super-Chama left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change destination branch to ccs and update.

components/src/core/components/Input/Autocomplete/AutocompleteInput.vue Outdated Show resolved Hide resolved
@udithaOHRM udithaOHRM changed the base branch from ent to ccs November 17, 2023 13:39
@Super-Chama Super-Chama deleted the branch orangehrm:ccs November 17, 2023 16:51
@udithaOHRM udithaOHRM deleted the feature/ccs-autocomplete-show-all-items branch November 17, 2023 17:24
@Super-Chama
Copy link
Member

Closing due to #741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Super-Chama Super-Chama Super-Chama requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@udithaOHRM @Super-Chama