Upstream 0.25.0 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly using build args as advised in the docs.
…t primarily breaks
…lated unit tests (fixes telia-oss#248)
New metadata file that supports the new 'load_var' Concourse statement
Add PR body in the metadata provided by 'get' steps
Indeed, in order to delete the correct comments, the golang code makes sure that comment's `Author.Login` is the same as current `Viewer.Login`. But with bot users, viewer's login is "githubApp[bot]" and author login is "githubApp". As a consequence, for the comparison to succeed, we need to remove any trailing "[bot]" suffix from both parties, and compare the resulting prefixes. This isue was originally submitted as telia-oss#245 and fixed later in monzo#4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to track changes introduced by https://github.com/cloudfoundry-community/github-pr-resource/releases/tag/v0.25.0