Feature/orm 1814 - Events #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rjborba
requested review from
g-francesca and
faustoq
and removed request for
g-francesca
rjborba
force-pushed
the
feature/orm-1814
branch
from
46ea174 to
8953071
Compare
|
Looks good to me @rjborba! I know the components readme was updated to reflect the new events, but It would be helpful to have a centralized place where finding all the emitted events. Can we just add a section to the global readme file to list them? |
I suggest us (as I spoke with Fausto) to have a link to the auto-generated documentation of the external components. That we we won't be ever out of date with the actual code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds custom events do OaramSearchBox and OramaChatBox.
Events, descriptions and payloads can be found here:
https://linear.app/oramasearch/issue/ORM-1814/epic-search-and-answers-events