Feature/ORM-1581 #22
Merged
Feature/ORM-1581 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ORM-1581 Desktop: implement search as modal
We have covered the mobile style when the modal is open (it takes full width/height on mobile), we have to style modal on desktop (>1024px) |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rjborba
approved these changes
Aug 5, 2024
packages/ui-stencil/src/components/internal/orama-chat-button/orama-chat-button.tsx
Show resolved
Hide resolved
| isScrolling = false | ||
| prevScrollTop = 0 | ||
| scrollTarget = 0 | ||
|
|
||
| handleFocus = () => { |
| showClearChat={false} | ||
| /> | ||
| <orama-search class={`${globalContext.currentTask === 'search' ? 'section-active' : 'section-inactive'}`} /> | ||
| {this.windowWidth <= 1024 && ( |
There was a problem hiding this comment.
shouldn't we be using mediaquery insterad?
There was a problem hiding this comment.
@rjborba do you mean to hide/show this element via CSS only? Or just to replace 1024 with a variable breakpoint?
I'm using JS here so we can avoid having two times the same element (orama-chat) in the dom.
This is basically the current
orama-modal
|_orama-search
|_**orama-chat** (to show on mobile only)
orama-sliding-panel (this is the slide in panel that we want to display on desktop only)
|_**orama-chat** (desktop only)
packages/ui-stencil/src/components/internal/orama-chat/orama-chat.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:exportdirective, that would be otherwise included in the compiled CSS. The:exportis now included in a temporary file that is created during the conversion process and it's deleted at the end of the processPreview