Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Chat Height #21

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Review Chat Height #21

merged 1 commit into from
Jul 31, 2024

Conversation

g-francesca
Copy link
Contributor

@g-francesca g-francesca commented Jul 31, 2024 •
edited
Loading

What changes:

  • By default the chat height is always 100% of the height of its outer container. So we're removing the magic number that we were setting before
  • This implies that the height (if the user wants to set a fixed one) must be set on the outer parent container, as previewed in storybook

Preview

@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orama-ui-components-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 10:47am

@rjborba rjborba force-pushed the uireview-chat-height branch from 263c70c to 2a6a35e Compare July 31, 2024 13:32
@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024

Someone is attempting to deploy this pull request to the OramaSearch Team on Vercel.

To accomplish this, the commit author's email address needs to be associated with a GitHub account.

Learn more about how to change the commit author information.

@rjborba rjborba merged commit 0d8f91d into main Jul 31, 2024
1 of 2 checks passed
@g-francesca g-francesca deleted the uireview-chat-height branch August 1, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-francesca @rjborba