Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ORM-1550-2 #19

Merged
merged 12 commits into from
Jul 30, 2024
Merged

Feature/ORM-1550-2 #19

merged 12 commits into from
Jul 30, 2024

Conversation

g-francesca
Copy link
Contributor

@g-francesca g-francesca commented Jul 29, 2024

This PR is to:

  • make sure that stencil global styles are imported in demo react, vue, angular project
  • add sourcesMap prop to give users a way to select the fields to use to display sources
    Ref ORM-1533

Copy link

linear bot commented Jul 29, 2024

ORM-1550 Source baseUrl and mapping

Hardcoded sources have been replaced with the real ones. However, there are still some points to improve/fix:

  • The path is relative, so we may want to pass a baseUrl to make the link work in different contexts ✅
  • The sources documents have different data structures, so we need to create some mapping (similar to what we did with resultsMapping) to display the correct fields (now we're displaying the fields we expect from orama doc)

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orama-ui-components-storybook ❌ Failed (Inspect) Jul 30, 2024 2:46pm

Copy link

linear bot commented Jul 29, 2024

ORM-1533 Bundle global style

Ensure that global styles are bundled when using the React/Vue/Angular wrapper for Stencil components

React ✅

Vue ✅

Angular ✅

@rjborba rjborba merged commit 23280d8 into main Jul 30, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants