Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ORM-1533 #18

Merged
merged 19 commits into from
Jul 29, 2024
Merged

Feature/ORM-1533 #18

merged 19 commits into from
Jul 29, 2024

Conversation

g-francesca
Copy link
Contributor

@g-francesca g-francesca commented Jul 29, 2024

Please remember the following updates:

  • Storybook theme customized: the Storybook theme has been customized with new colors, and the Orama logo has replaced the Storybook logo.
  • Design token section added: color tokens have been reviewed and a design tokens section has been added
    • Design tokens for colors have been documented, and we will also include tokens for spacing, radius, etc.
    • Colors have been categorized into Primitive, Semantic, and Element. You can use the Storybook theme switcher to toggle between values for light and dark themes.
  • Convert SCSS to js: A script has been added to convert SCSS tokens into a JS file. You can now run the command pnpm convert-scss-to-js to generate a JS file containing all the colors in JS format. Currently, only colors are converted, but we will include others if needed. Conversion uses the :export directive, therefore we need to update it in case new primitive tokens will be added. Also, at the moment you have to run this command manually, at some point we should automate this to be sure the js file is always updated.
  • Welcome page has been added. We will review both the design and content for this page, providing a more inviting and useful entry point. 💅

Preview: https://orama-ui-components-storybook-kqsvi2gb3-oramasearch.vercel.app

Copy link

linear bot commented Jul 29, 2024

ORM-1533 Bundle global style

Ensure that global styles are bundled when using the React/Vue/Angular wrapper for Stencil components

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orama-ui-components-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 10:33am

Copy link
Collaborator

@rjborba rjborba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@g-francesca g-francesca merged commit 44cb988 into main Jul 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants