Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/orm-1550 #15

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Feature/orm-1550 #15

merged 4 commits into from
Jul 25, 2024

Conversation

g-francesca
Copy link
Contributor

  • adding sourceBaseURL
  • add relatedQueries to interaction
  • fixing some mobile style

@linear Linear
Copy link

linear bot commented Jul 25, 2024

ORM-1550 Source baseUrl and mapping

Hardcoded sources have been replaced with the real ones. However, there are still some points to improve/fix:

  • The path is relative, so we may want to pass a baseUrl to make the link work in different contexts
  • The sources documents have different data structures, so we need to create some mapping (similar to what we did with resultsMapping) to display the correct fields (now we're displaying the fields we expect from orama doc)

@vercel Vercel
Copy link

vercel bot commented Jul 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orama-ui-components-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 2:59pm

@g-francesca g-francesca merged commit 1db52b8 into main Jul 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjborba rjborba rjborba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-francesca @rjborba