Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed error on updatingCompleted #5

Merged
merged 2 commits into from
Sep 23, 2024
Merged

fix: fixed error on updatingCompleted #5

merged 2 commits into from
Sep 23, 2024

Conversation

giogaspa
Copy link
Contributor

@giogaspa giogaspa commented Sep 22, 2024 •
edited
Loading

Hi, this can fix this issue #4 .
I've tested with PostgreSQL and SQLite and it works.

@micheleriva
Copy link
Member

Hey @giogaspa thank you for this! I'll ask @faustoq to review the PR.

@raiindev raiindev self-requested a review September 23, 2024 13:11
raiindev
raiindev approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@raiindev raiindev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Hey @giogaspa the PR is perfect! Could you update your branch with the latest changes? (I fixed the GH Workflow that is causing the failing check)

@giogaspa
Copy link
Contributor Author

Hi @raiindev, I've just updated. Thx.

@raiindev raiindev merged commit d87e20d into oramasearch:main Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raiindev raiindev raiindev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giogaspa @micheleriva @raiindev