Improve Ruby string interning #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we always extracted the precise range of bytes we needed when looking up an entry in the frozen string table. If an entry already existed, we'd discard that extracted range in favor of what was already in the cache. This change defers making a copy of the string's bytes until we need to insert into the cache. For situations with many cache hits this approach can be much faster.
…ble. By restructuring to work with `InternalByteArray`, we can now support working with native strings as well. The `InternalByteArray` will make a copy of the native memory into a Java `byte[]`, which won't change behind our backs.
… cache key to save memory.
oracle-contributor-agreement
bot
added
the
OCA Verified
nirvdrum
force-pushed
the
improve-ruby-string-intern
branch
from
44ed828
to
3f4f5c4
Compare
eregon
approved these changes
Aug 17, 2023
Comment on lines
+46
to
+47
| /** Supports the creation of a cache key using a subset of bytes. This key *must* be used for lookups only. If you | ||
| * want to insert into the cache, you *must* use the result of {@link #makeCacheable(boolean)}. |
There was a problem hiding this comment.
This is super helpful to understand this code/class, thanks!
Comment on lines
101
to
103
| if (bytes == null) { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
bytes can never be null, right? I'll just remove this then.
(it probably comes from Arrays#hashCode checking that)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially the follow-up work to #3185. I didn't realize that rebasing my branch and pushing that up was going to break the branch link in GitHub. Since it did, I can't re-open that PR. I'm sorry for the churn.