Skip to content

Commit

Permalink
[GR-17457] IGV must be run on a LTS JDK so always do that for jt igv
Browse files Browse the repository at this point in the history
PullRequest: truffleruby/4374
  • Loading branch information
eregon committed Oct 21, 2024
2 parents 83e825d + b45c865 commit 44ded82
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 1 deletion.
22 changes: 21 additions & 1 deletion src/main/java/org/truffleruby/extra/TruffleGraalNodes.java
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,26 @@ Object blackhole(Object value) {

}

@CoreMethod(names = "boundary", onSingleton = true)
public abstract static class BoundaryNode extends CoreMethodArrayArgumentsNode {

@TruffleBoundary(allowInlining = false)
@Specialization
Object boundary() {
return nil;
}
}

@CoreMethod(names = "boundary_allow_inlining", onSingleton = true)
public abstract static class BoundaryAllowInliningNode extends CoreMethodArrayArgumentsNode {

@TruffleBoundary(allowInlining = true)
@Specialization
Object boundaryAllowInlining() {
return nil;
}
}

@CoreMethod(names = "total_compilation_time", onSingleton = true)
public abstract static class TotalCompilationTimeNode extends CoreMethodArrayArgumentsNode {

Expand All @@ -236,7 +256,7 @@ public abstract static class TotalCompilationTimeNode extends CoreMethodArrayArg
@SuppressFBWarnings("LI_LAZY_INIT_STATIC")
@TruffleBoundary
@Specialization
final long totalCompilationTime() {
long totalCompilationTime() {
if (bean == null) {
var compilationMXBean = ManagementFactory.getCompilationMXBean();
VarHandle.storeStoreFence();
Expand Down
2 changes: 2 additions & 0 deletions tool/jt.rb
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
ENV['GEM_HOME'] = File.expand_path(ENV['GEM_HOME']) if ENV['GEM_HOME']

JDK_VERSIONS = %w[latest 21]
LTS_JDK_VERSION = '21'
DEFAULT_JDK_VERSION = 'latest'

MRI_TEST_RELATIVE_PREFIX = 'test/mri/tests'
Expand Down Expand Up @@ -2367,6 +2368,7 @@ def graph(*args)

def igv
compiler = "#{GRAAL_DIR}/compiler"
@jdk_version = LTS_JDK_VERSION
mx('igv', chdir: compiler)
end

Expand Down

0 comments on commit 44ded82

Please sign in to comment.