feat: find repo from latest artifact when provided artifact has none #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Ben Selwyn-Smith <[email protected]>
benmss
force-pushed
the
benmss/latest-repo-finder
branch
from
70daa62
to
a2b6ba9
Compare
behnazh-w
reviewed
Nov 29, 2024
| @@ -133,7 +133,7 @@ def to_repo_path(purl: PackageURL, available_domains: list[str]) -> str | None: | |||
| ) | |||
|
|
|||
|
|
|||
| def find_source(purl_string: str, input_repo: str | None) -> bool: | |||
| def find_source(purl_string: str, input_repo: str | None, latest_version_fallback: bool = True) -> bool: | |||
There was a problem hiding this comment.
It seems that the repo finder used in the analyzer module is inconsistent with this implementation, as it doesn't utilize the same fallback for the latest version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Repo Finder by making it check for repositories using the latest version of an artifact if the provided version does not contain that information. This latest version finding behaviour is also added for the case where a Java PURL was provided without a version, and is added for the
find-sourcecommand.