chore: do not pass *args to SQLALchemy DeclarativeBase class #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tromai
approved these changes
Oct 16, 2023
Signed-off-by: behnazh-w <[email protected]>
behnazh-w
force-pushed
the
fix-repository-orm-args
branch
from
f3f995c to
c202e98
Compare
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
Signed-off-by: behnazh-w <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__init__function in SQAlchemy'sDeclarativeBaseclass does not take positional arguments. TheRepositoryORM mapping however passes*argstoDeclarativeBase, which is not correct. So far we haven't run into any issues because we always pass keyword arguments while initializingRepositoryinstances.This PR fixes this issue by not passing
*argsto the parentDeclarativeBaseclass.