Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVAVSCODE-80] Renamed downloaded jdk binaries so that it is not replaced by the already present binaries #82

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

Achal1607
Copy link
Member

Renamed downloaded extracted jdk binaries so that even if openJDK and oracle JDK binaries are downloaded in the same directory they are not replaced by each other.

closes #80

@Achal1607 Achal1607 requested a review from lahodaj November 16, 2023 11:01
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 16, 2023
…nloader in same directory

Signed-off-by: Achal Talati <[email protected]>
@Achal1607 Achal1607 requested a review from lahodaj November 27, 2023 17:07
Signed-off-by: Achal Talati <[email protected]>
@Achal1607 Achal1607 requested a review from lahodaj December 18, 2023 07:48
lahodaj
lahodaj previously approved these changes Jan 4, 2024
Copy link
Member

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK.

arvindaprameya
arvindaprameya previously approved these changes Jan 8, 2024
Copy link
Member

@arvindaprameya arvindaprameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Achal1607 Achal1607 dismissed stale reviews from arvindaprameya and lahodaj via 2ef2354 January 8, 2024 06:04
@arvindaprameya arvindaprameya self-requested a review January 8, 2024 06:06
Copy link
Member

@arvindaprameya arvindaprameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arvindaprameya arvindaprameya merged commit ca0e7e9 into oracle:main Jan 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JDK downloader: Allow download of Oracle JDK and openJDK binaries in the same directory
3 participants