Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JAVAVSCODE-78] Added checksum match for jdk downloader #81

Merged
merged 2 commits into from
Dec 1, 2023
Merged

[JAVAVSCODE-78] Added checksum match for jdk downloader #81

merged 2 commits into from
Dec 1, 2023

Conversation

Achal1607
Copy link
Member

Added checksum match after downloading JDK binaries in JDK downloader feature

closes #78

@Achal1607 Achal1607 requested a review from lahodaj November 16, 2023 09:45
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 16, 2023
lahodaj
lahodaj requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments for consideration inline

vscode/src/jdkDownloader.ts Outdated Show resolved Hide resolved
vscode/src/jdkDownloader.ts Outdated Show resolved Hide resolved
@Achal1607 Achal1607 requested a review from lahodaj November 27, 2023 17:31
lahodaj
lahodaj approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

arvindaprameya
arvindaprameya approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@arvindaprameya arvindaprameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arvindaprameya arvindaprameya merged commit ccefba5 into oracle:main Dec 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahodaj lahodaj lahodaj approved these changes

@arvindaprameya arvindaprameya arvindaprameya approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement checksum match in JDK Downloader
3 participants
@Achal1607 @arvindaprameya @lahodaj