[JAVAVSCODE-71] Updated download.jdk command configuration to open JDK downloader window even if no folder is open in workspace #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dow even if no folder is open in workspace Signed-off-by: Achal Talati <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
lahodaj
reviewed
Nov 27, 2023
vscode/src/extension.ts
Outdated
| @@ -444,6 +444,10 @@ export function activate(context: ExtensionContext): VSNetBeansAPI { | |||
| throw `Client ${c} doesn't support new project`; | |||
| } | |||
| })); | |||
| context.subscriptions.push(vscode.commands.registerCommand(COMMAND_PREFIX + ".download.jdk", async () => { | |||
| let c : LanguageClient = await client; | |||
There was a problem hiding this comment.
I wonder about the await client here - is that necessary? I think many other commands are waiting for the client (which I think in practice means "wait for the language server to come up, and connect to the language client embedded in the extension", but I can be wrong), as they actually use the language server. But this specific command runs without the server, and should even run when the server is unable to run (e.g. due to a missing JDK).
There was a problem hiding this comment.
Sorry, I thought we need to wait for the language server but you are correct. So, I have updated the commit accordingly. Thanks.
Signed-off-by: Achal Talati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier only if some Java project or Java file was open in the workspace then only jdk downloader command could be executed from the command palette. So, it's configuration has been updated so that it can be executed even if workspace is empty.
Closes #71