Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dev dependency #344

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

sid-srini
Copy link
Member

Adding the dev-dependencies upgrade that was done in PR #322 to main.

Note: closes #341

@sid-srini sid-srini added this to the JVSC 23.1.0 milestone Dec 10, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 10, 2024
@sid-srini sid-srini requested a review from Achal1607 December 10, 2024 20:20
This will ensure that CI runs will perform both unit and integration
tests.

Signed-off-by: Siddharth Srinivasan <[email protected]>
Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@sid-srini sid-srini merged commit 91a65d3 into oracle:main Dec 11, 2024
3 checks passed
@sid-srini sid-srini deleted the upgrade-dev-dependency branch December 11, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants